fix: freeze problem when $ref is deeply nested (#1083)

Author: YukiKitagata

packages/core/src/resolvers/object.ts

@@ -4,7 +4,7 @@ import { ContextSpecs, ResolverValue } from '../types';
 import { jsDoc } from '../utils';
 import { resolveValue } from './value';
 
-export const resolveObject = ({
+const resolveObjectOriginal = ({
   schema,
   propName,
   combined = false,
@@ -76,3 +76,39 @@ export const resolveObject = ({
 
   return resolvedValue;
 };
+
+const resolveObjectCacheMap = new Map<string, ResolverValue>();
+
+export const resolveObject = ({
+  schema,
+  propName,
+  combined = false,
+  context,
+}: {
+  schema: SchemaObject | ReferenceObject;
+  propName?: string;
+  combined?: boolean;
+  context: ContextSpecs;
+}): ResolverValue => {
+  const hashKey = JSON.stringify({
+    schema,
+    propName,
+    combined,
+    specKey: context.specKey,
+  });
+
+  if (resolveObjectCacheMap.has(hashKey)) {
+    return resolveObjectCacheMap.get(hashKey)!;
+  }
+
+  const result = resolveObjectOriginal({
+    schema,
+    propName,
+    combined,
+    context,
+  });
+
+  resolveObjectCacheMap.set(hashKey, result);
+
+  return result;
+};

tests/configs/default.config.ts

@@ -87,4 +87,11 @@ export default defineConfig({
       mock: true,
     },
   },
+  'deeply-nested-refs': {
+    input: '../specifications/deeply-nested-refs.yaml',
+    output: {
+      schemas: '../generated/default/deeply-nested-refs/model',
+      target: '../generated/default/deeply-nested-refs/endpoints.ts',
+    },
+  },
 });

tests/specifications/deeply-nested-refs.yaml

@@ -0,0 +1,105 @@
+openapi: 3.0.0
+info:
+  title: Deeply nested refs
+  description: ''
+  version: 1.0.0
+paths:
+  /deeply-nested:
+    get:
+      summary: deeply nested
+      responses:
+        '200':
+          description: OK
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/DeeplyNestedRefSchema1'
+components:
+  schemas:
+    DeeplyNestedRefSchema1:
+      type: object
+      properties:
+        item1:
+          type: array
+          items:
+            allOf:
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema1'
+        item2:
+          type: array
+          items:
+            allOf:
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema2'
+        item_all:
+          type: array
+          items:
+            allOf:
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema1'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema2'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema3'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema4'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema5'
+    DeeplyNestedRefSchema2:
+      type: object
+      properties:
+        item3:
+          type: object
+          allOf:
+            - $ref: '#/components/schemas/DeeplyNestedRefSchema3'
+        item_all:
+          type: array
+          items:
+            allOf:
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema1'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema2'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema3'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema4'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema5'
+    DeeplyNestedRefSchema3:
+      type: object
+      properties:
+        item4:
+          type: object
+          allOf:
+            - $ref: '#/components/schemas/DeeplyNestedRefSchema4'
+        item_all:
+          type: array
+          items:
+            allOf:
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema1'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema2'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema3'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema4'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema5'
+    DeeplyNestedRefSchema4:
+      type: object
+      properties:
+        item5:
+          type: object
+          allOf:
+            - $ref: '#/components/schemas/DeeplyNestedRefSchema5'
+        item_all:
+          type: array
+          items:
+            allOf:
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema1'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema2'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema3'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema4'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema5'
+    DeeplyNestedRefSchema5:
+      type: object
+      properties:
+        item1:
+          type: array
+          items:
+            allOf:
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema1'
+        item_all:
+          type: array
+          items:
+            allOf:
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema1'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema2'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema3'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema4'
+              - $ref: '#/components/schemas/DeeplyNestedRefSchema5'