fix: unstable reference (Issue 1359) (#1374)

* Issue 1359

* added import for useCallback

* revert lock file changes

* chore: fix formatting

Author: henkerik

packages/query/src/index.ts

@@ -45,6 +45,18 @@ import {
   vueUnRefParams,
 } from './utils';
 
+const REACT_DEPENDENCIES: GeneratorDependency[] = [
+  {
+    exports: [
+      {
+        name: 'useCallback',
+        values: true,
+      },
+    ],
+    dependency: 'react',
+  },
+];
+
 const AXIOS_DEPENDENCIES: GeneratorDependency[] = [
   {
     exports: [
@@ -208,6 +220,7 @@ export const getReactQueryDependencies: ClientDependenciesBuilder = (
     packageJson?.devDependencies?.['@tanstack/react-query'];
 
   return [
+    ...(hasGlobalMutator ? REACT_DEPENDENCIES : []),
     ...(!hasGlobalMutator ? AXIOS_DEPENDENCIES : []),
     ...(hasParamsSerializerOptions ? PARAMS_SERIALIZER_DEPENDENCIES : []),
     ...(hasReactQuery && !hasReactQueryV4
@@ -451,7 +464,7 @@ const generateQueryRequestFunction = (
           response.definition.success || 'unknown'
         }>();
 
-        return (\n    ${propsImplementation}\n ${
+        return useCallback((\n    ${propsImplementation}\n ${
           isRequestOptions && mutator.hasSecondArg
             ? `options${context.output.optionsParamRequired ? '' : '?'}: SecondParameter<ReturnType<typeof ${mutator.name}>>,`
             : ''
@@ -461,7 +474,7 @@ const generateQueryRequestFunction = (
         return ${operationName}(
           ${mutatorConfig},
           ${requestOptions});
-        }
+        }, [${operationName}])
       }
     `;
     }

tests/package.json

@@ -33,6 +33,7 @@
     "@tanstack/react-query": "^4.22.0",
     "@tanstack/svelte-query": "^4.24.9",
     "@tanstack/vue-query": "^4.22.0",
+    "@types/react": "18.3.2",
     "axios": "^0.26.1",
     "msw": "^2.0.2",
     "swr": "^2.2.4",

tests/yarn.lock

@@ -139,6 +139,19 @@
   resolved "https://registry.yarnpkg.com/@types/js-levenshtein/-/js-levenshtein-1.1.2.tgz#e88f365d6a34beeaff9654706b99a790b5a5aabd"
   integrity sha512-/NCbMABw2uacuyE16Iwka1EzREDD50/W2ggRBad0y1WHBvAkvR9OEINxModVY7D428gXBe0igeVX7bUc9GaslQ==
 
+"@types/prop-types@*":
+  version "15.7.12"
+  resolved "https://registry.yarnpkg.com/@types/prop-types/-/prop-types-15.7.12.tgz#12bb1e2be27293c1406acb6af1c3f3a1481d98c6"
+  integrity sha512-5zvhXYtRNRluoE/jAp4GVsSduVUzNWKkOZrCDBWYtE7biZywwdC2AcEzg+cSMLFRfVgeAFqpfNabiPjxFddV1Q==
+
+"@types/react@18.3.2":
+  version "18.3.2"
+  resolved "https://registry.yarnpkg.com/@types/react/-/react-18.3.2.tgz#462ae4904973bc212fa910424d901e3d137dbfcd"
+  integrity sha512-Btgg89dAnqD4vV7R3hlwOxgqobUQKgx3MmrQRi0yYbs/P0ym8XozIAlkqVilPqHQwXs4e9Tf63rrCgl58BcO4w==
+  dependencies:
+    "@types/prop-types" "*"
+    csstype "^3.0.2"
+
 "@types/statuses@^2.0.1":
   version "2.0.3"
   resolved "https://registry.yarnpkg.com/@types/statuses/-/statuses-2.0.3.tgz#9286ef63c99ed9fd739db7f7db5ab9bd6160ab33"
@@ -445,6 +458,11 @@ cross-spawn@^6.0.5:
     shebang-command "^1.2.0"
     which "^1.2.9"
 
+csstype@^3.0.2:
+  version "3.1.3"
+  resolved "https://registry.yarnpkg.com/csstype/-/csstype-3.1.3.tgz#d80ff294d114fb0e6ac500fbf85b60137d7eff81"
+  integrity sha512-M1uQkMl8rQK/szD0LNhtqxIPLpimGm8sOBwU7lLnCpSbTyY3yeU1Vc7l4KT5zT4s/yOxHH5O7tIuuLOCnLADRw==
+
 csstype@^3.1.1:
   version "3.1.2"
   resolved "https://registry.yarnpkg.com/csstype/-/csstype-3.1.2.tgz#1d4bf9d572f11c14031f0436e1c10bc1f571f50b"