fix(query): enabled reactivity fix (new) #1080
Merged
+152
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
approved these changes
Nov 29, 2023
|
When do you expect to ship 6.22.0? :) |
I hope that as soon as #1085 is merged, which is currently ready for re-review, so probably very soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Ensures that query
enabledoption is reactive (disabled when parameters are falsy).Will fix #943
Related PRs
Based on #944, @BenGane my colleague agreed for me to take it over.
Todos
Steps to Test or Reproduce
Test included, to rebuild all and run all tests use this: