Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enum string escape can be nullable #1081

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

dipsaus9
Copy link
Contributor

@dipsaus9 dipsaus9 commented Nov 29, 2023

Status

Ready

Fix #1082

Description

Enum can be optional within openAPI 3.0.0. This PR adds support for optional enum and mocks. https://swagger.io/docs/specification/data-models/enums/.

Todos

  • Tests
  • Changelog Entry (unreleased) - not sure what to do?

Steps to Test or Reproduce

I added a mock option within the default configuration and included it with the used URL's. This PR contains a fix for the same problem.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@melloware
Copy link
Collaborator

Can you open an issue so I can link this PR to the issue?

I am not fully understanding what this fixes so issue ticket should help clear that up

Copy link

@martinpalmieri martinpalmieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dipsaus9
Copy link
Contributor Author

dipsaus9 commented Nov 29, 2023

Opened a Issue describing the problem a bit more

@melloware melloware added the bug Something isn't working label Nov 29, 2023
@melloware melloware added this to the 6.22.0 milestone Nov 29, 2023
@melloware melloware merged commit ceb18bf into orval-labs:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nullable enums can not be mocked
3 participants