Array schema values aren't marked as readonly

[ezequiel]

What are the steps to reproduce this issue?

{
  "swagger": "2.0",
  "info": {
    "title": "My API",
    "version": "1.0"
  },
  "paths": {},
  "definitions": {
    "models.ThingDescription": {
      "type": "object",
      "properties": {
        "text": {
          "type": "string"
        }
      }
    },
    "models.Thing": {
      "type": "object",
      "properties": {
        "ThingDescriptions": {
          "type": "array",
          "items": {
            "$ref": "#/definitions/models.ThingDescription"
          },
          "readOnly": true
        }
      }
    }
  }
}

What happens?

When an array schema has "readOnly": true set, the field value isn't marked as readonly. e.g. below, field ThingDescriptions is correctly marked as readonly, but the value ModelsThingDescription[] isn't

export type ModelsThingDescription = {
  text?: string;
};

export type ModelsThing = {
  readonly ThingDescriptions?: ModelsThingDescription[];
};

What were you expecting to happen?

ModelsThingDescription[] is marked as readonly

export type ModelsThingDescription = {
  text?: string;
};

export type ModelsThing = {
  readonly ThingDescriptions?: readonly ModelsThingDescription[];
};

What versions are you using?

Operating System: Mac OS Ventura
Package Version: latest
Browser Version: Chrome latest

[ezequiel]

My hunch is we just have to check if the schema is readOnly here, and prepend "readonly " to the value: https://github.com/anymaniax/orval/blob/8bf7cbf48709a695566b969efe2950df1a0a7546/packages/core/src/getters/array.ts#L27-L29

[melloware]

want me to assign to you?