Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add optional flag to force number type instead of bigint #841

Merged
merged 2 commits into from Apr 25, 2023

Conversation

GBDev13
Copy link
Contributor

@GBDev13 GBDev13 commented Apr 24, 2023

Status

READY

Description

The recent change from to add support for bigints caused issues in frontend code, as commented here

So, in this PR, I just added an optional field called useNumberTypeForBigInt that when true, forces the typing to always be number, instead of bigint.

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

@vercel
Copy link

vercel bot commented Apr 24, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @anymaniax on Vercel.

@anymaniax first needs to authorize it.

@GBDev13 GBDev13 mentioned this pull request Apr 24, 2023
@anymaniax anymaniax merged commit a2798af into anymaniax:master Apr 25, 2023
2 of 3 checks passed
@anymaniax
Copy link
Owner

@GBDev13 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants