fix(core): inconsistent kebab casing comparison #937
Merged
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing an issue where operationNames were being filtered out and not provided to builder.footer. generateTargetTags returns kebab-cased tags which are then compared to operation tags which have not been run through the kebab routine. map all operation tags with kebab prior to checking that the tags include a tag.
|
Someone is attempting to deploy a commit to a Personal Account owned by @anymaniax on Vercel. @anymaniax first needs to authorize it. |
|
Hello @fergiektid, thanks for the pr. We should kebab both side to be sure no? |
Fixing an issue where operationNames were being filtered out and not provided to builder.footer. generateTargetTags returns kebab-cased tags which are then compared to operation tags which have not been run through the kebab routine. map all operation tags with kebab prior to checking that the tags include a tag. Added some additional unit tests to ensure that the kebab routine is Idempotent.
Yes, In this specific instance, I don't think we need to because it's already been called for the right hand side. But I don't see any harm in doing it again as a safety net against future refactoring. I've added a test for the kebab case routine to ensure that the kebab routine remains Idempotent, since we are potentially calling it multiple times with input which has already been through the routine. I have updated the PR. |
|
Can you resolve the conflict pls? |
melloware
previously approved these changes
Oct 20, 2023
melloware
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Fix #936
Description
This PR aims to resolve issue #936. Which causes potentially invalid typescript to be generated by Orval. Need to ensure that we are comparing like for like when searching the array of tags for a specific tag.
Todos
Steps to Test or Reproduce
#936 (comment)