Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make order of imports and object properties deterministic #965

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

GMierzwa
Copy link
Contributor

Status

READY

Description

Resolves #703 and #780.

Currently the order of imports and properties inside an object may vary between executions, generating unnecessary diffs. The changes here were to simply sort those fields during code generation.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vercel
Copy link

vercel bot commented Oct 11, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @anymaniax on Vercel.

@anymaniax first needs to authorize it.

Copy link
Collaborator

@anymaniax anymaniax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@anymaniax anymaniax merged commit a4cca88 into orval-labs:master Oct 19, 2023
@lyrixx
Copy link

lyrixx commented Feb 19, 2025

Hello, something went wrong with this PR I guess.

On the related issue, I can read

added this to the 6.20.0 milestone on Nov 13, 2023

But it's not included in the release v6.20.0

I tried locally to find the commit, But I can't
I tried on github, and got:

This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

It looks like this PR has been lost.

@melloware
Copy link
Collaborator

can you try the latest 7.5.0 version?

@lyrixx
Copy link

lyrixx commented Feb 19, 2025

I was on 6.x, and I was afraid to upgrade on 7.x
I tested and indeed the diff is much more stable.
Now I have plenty of other errors, but that's another story.
BTW, do you have an upgrade guide? It seems enum has changed.

@melloware
Copy link
Collaborator

@lyrixx your issue might be this: #1911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSW definitions are non-deterministic
4 participants