Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all uses of system calls #150

Open
joshcarp opened this issue Jul 13, 2020 · 0 comments
Open

Remove all uses of system calls #150

joshcarp opened this issue Jul 13, 2020 · 0 comments

Comments

@joshcarp
Copy link
Contributor

for the sake of reusability and reliability it would greatly simplify this project if we removed all uses of os.exec calls:

  1. In sysl modules
  2. getting the git remote:
    cmd := exec.Command("git", "config", "--get", "remote.origin.url")

This means that it can more reliably run in different environments (wasm/docker).
As for the lost functionality; I think the current solutions are bandaids and there are more robust ways of getting the same functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant