Refactor shorter defaults #34350
Merged
Refactor shorter defaults #34350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
eumiro
requested review from
potiuk,
ashb,
jedcunningham,
eladkal,
o-nikolas,
ryanahamilton,
bbovenzi,
pierrejeambrun,
ephraimbuddy,
kaxil and
XD-DENG
as code owners
jscheffl
approved these changes
Sep 13, 2023
uranusjr
reviewed
Sep 14, 2023
airflow/api/common/trigger_dag.py
Outdated
Comment on lines
57
to
58
| execution_date = execution_date if execution_date else timezone.utcnow() | ||
| if execution_date is None: | ||
| execution_date = timezone.utcnow() |
There was a problem hiding this comment.
Would execution_date = execution_date or timezone.utcnow() work?
There was a problem hiding this comment.
Yes. However, while other cases are c = a or b and we need to attribute something to c, this is a = a or b, so if a is trueish, it is not modified.
There was a problem hiding this comment.
Yeah and I don’t think that’s a problem for this particular case.
|
Conflicts |
uranusjr
approved these changes
Oct 12, 2023
jscheffl
approved these changes
Oct 21, 2023
|
Rebased to see if it works with latest main. |
eladkal
approved these changes
Oct 21, 2023
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.