Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger as a valid option for the db clean command #34908

Merged
merged 3 commits into from Oct 30, 2023

Conversation

syedahsn
Copy link
Contributor

closes: #34906
This is a potential solution to the issue mentioned above. There is an existing command, airflow db clean that removes old records from the DB. This command currently does not support the triggers table, so it cannot be used. This PR solves the issue linked above by allowing the user to manually delete outdated records in the triggers table, which also removes the notification about the Trigger not being active.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@syedahsn
Copy link
Contributor Author

@dstandish do you mind taking a look at this issue? I'm wondering if this is the best way to solve the problem.

Copy link
Contributor

@dstandish dstandish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to clear the record?

Copy link
Contributor

@dstandish dstandish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a problem with this. But seems quite rare that anyone would need it.

@syedahsn syedahsn marked this pull request as ready for review October 23, 2023 17:08
@vincbeck vincbeck merged commit d07e66a into apache:main Oct 30, 2023
44 checks passed
@vincbeck vincbeck deleted the syedahsn/add-trigger-table-to-db-clean branch October 30, 2023 17:10
@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Nov 19, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.0 milestone Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear old Triggers when Triggerer is not running
4 participants