Bug fix fetch_callback of Partial Subset DAG #35256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that there may be a bug where if a partial_subset dag is generated on a DAG with
on_success_callback
oron_failure_callback
functions defined on it, then it might try to look for a TI that is not actually a part of the partial subset DAG. This is because we fetch the last TI available from the DagRun withinDAG.fetch_callback
, and a DagRun isn't aware of the concept of a partial subset. Henceti.task = dag.get_task(ti.task_id)
results in aTaskNotFound
exception.In this PR, we are:
DAG.fetch_callback
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.