Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dag-run.rst to mention Airflow's support for extended cron syntax through croniter #35342

Merged
merged 1 commit into from Nov 2, 2023

Conversation

Rafnel
Copy link
Contributor

@Rafnel Rafnel commented Nov 1, 2023

Without diving into the source code, it is unclear to readers that Airflow supports an extended cron syntax due to its usage of croniter. My team spends a lot of time making schedules for our DAGs and I believe it would be helpful to mention this. This documentation change should point readers to croniter for all supported cron formats. Also it provides an example of an extended syntax cron expression which Airflow supports.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

…tax through croniter

Without diving into the source code, it is unclear to readers that Airflow supports an extended cron syntax due to its usage of croniter. This documentation change should point readers to croniter for all supported cron formats.
Copy link

boring-cyborg bot commented Nov 1, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit 3f4028f into apache:main Nov 2, 2023
45 checks passed
Copy link

boring-cyborg bot commented Nov 2, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@Rafnel Rafnel deleted the patch-1 branch November 3, 2023 12:59
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Nov 10, 2023
…tax through croniter (apache#35342)

Without diving into the source code, it is unclear to readers that Airflow supports an extended cron syntax due to its usage of croniter. This documentation change should point readers to croniter for all supported cron formats.
@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Nov 20, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.0 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants