Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate usage of the re2 regex engine in the .airflowignore documentation. #35663

Merged
merged 5 commits into from Nov 20, 2023

Conversation

tshirtman
Copy link
Contributor

As the engine was changed in #32303, and the feature set of this engine is a bit specific, it seems useful to be explicit about it.

Added a short explanation about it in the dags documenatiton, with a link to the re2 syntax wiki page.

related: #32303

…ation.

As the engine was changed in !32303, and the feature set of this engine is a bit specific, it seems useful to be explicit about it.
Copy link

boring-cyborg bot commented Nov 15, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Nov 15, 2023

You need to use double backticks in .rst :)

@eladkal eladkal added the type:doc-only Changelog: Doc Only label Nov 20, 2023
@eladkal eladkal added this to the Airflow 2.7.4 milestone Nov 20, 2023
@potiuk potiuk merged commit 861d31d into apache:main Nov 20, 2023
47 checks passed
Copy link

boring-cyborg bot commented Nov 20, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@tshirtman tshirtman deleted the patch-1 branch November 20, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants