Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Trigger UI to use HTTP POST in web ui #36026

Merged
merged 3 commits into from Dec 2, 2023
Merged

Change Trigger UI to use HTTP POST in web ui #36026

merged 3 commits into from Dec 2, 2023

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Dec 2, 2023

This PR changes the web UI trigger form to be shown always when calling via GET. Before it was possible to "accidentally" make a trigger when no form parameters were specified in a DAG and you passed the trigger URL along.

Now the UI uses POST when clicking.

How to test:

  • Open your test env on the branch and run it via breeze on this branch
  • Open the UI and log-in with your user
  • Use the same window keeping the login context and call http://localhost:28080/dags/dataset_produces_1/trigger with the browser and see the trigger form popping up (Which in main will directly execute a trigger)

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Dec 2, 2023
@jscheffl jscheffl added this to the Airflow 2.8.0 milestone Dec 2, 2023
potiuk
potiuk reviewed Dec 2, 2023
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me as well.

@jscheffl jscheffl merged commit f5d8027 into apache:main Dec 2, 2023
47 checks passed
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Dec 5, 2023
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
@jscheffl @ephraimbuddy
Change Trigger UI to use HTTP POST in web ui (#36026)
d6ce328 
* Change Trigger UI to use HTTP POST in web ui, GET always shows trigger form
* Adjust tests to changed behavior of trigger handling, expects data submitted in POST

(cherry picked from commit f5d8027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashb ashb ashb approved these changes

@potiuk potiuk potiuk approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jscheffl @ashb @potiuk @ephraimbuddy