Update reset_user_sessions to work from either CLI or web #36056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the `reset_user_sessions` method to not class `flash` if it is not being run within the web context but to log the warning message instead. Without this change, `flask fab reset-password` would fail if a warning message needed to be printed.
pdebelak
force-pushed
the
reset-password-cli-no-flash
branch
from
fdffeac
to
1f88ad1
Compare
vincbeck
approved these changes
Dec 4, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 5, 2023
This updates the `reset_user_sessions` method to not class `flash` if it is not being run within the web context but to log the warning message instead. Without this change, `flask fab reset-password` would fail if a warning message needed to be printed. (cherry picked from commit 7ececfd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
reset_user_sessionsmethod to not callflashif it is not being run within the web context but to log the warning message instead. Without this change,flask fab reset-passwordwould fail if a warning message needed to be printed.closes: #36054
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.