feat: make `regex-uri` able to use nginx variables for Plugin[Proxy-rewrite] #11225

V1endr3 · 2024-05-05T00:33:32Z

Make regex-uri of proxy-rewrite able to use nginx variables.

[v] I have explained the need for this PR and the problem it solves
[v] I have explained the changes or the new features added to this PR
I have added tests corresponding to this change
[v] I have updated the documentation to reflect this change
[v] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Tests have been done in docker env, but no new test cases added.
This's my first PR for apisix & lua, if there is any bad smell of code, pls let me know. THX :D

using local instead of global variable _

shreemaan-abhishek · 2024-05-06T04:55:09Z

@V1endr3 please describe your proposal first in #11224

V1endr3 · 2024-05-06T06:28:35Z

@V1endr3 please describe your proposal first in #11224

done, pls check it.

shreemaan-abhishek · 2024-05-08T02:09:21Z

I have marked this PR as a draft. We can start the review once we have a consensus from the community in #11224

V1endr3 and others added 7 commits May 5, 2024 04:52

feat: allow regex_uri using both path variables and nginx env-params

4a0ace4

improv: regroup code structure

bcc0318

docs: updated docs to reflect this change

b84707a

improv: fix by code lint

72f3063

fix: regex pattern only apply to $ begin with [a-zA-Z]

bbe94a9

improv: code lint improv

62ee6fc

using local instead of global variable _

fix: proxy-rewrite.lua

8d39364

shreemaan-abhishek marked this pull request as draft May 8, 2024 02:08

Provide feedback