Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose arrow_json::writer::encoder::make_encoder_impl() for re-use in custom encoders #5733

Open
eldargab opened this issue May 7, 2024 · 1 comment
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@eldargab
Copy link

eldargab commented May 7, 2024

In our project we have a set of JSON serialization rules not covered by arrow_json.

For example, there are binary columns that already contain a valid JSON that needs to be just embedded "as is" into the output stream. We also have cases when we'd like to serialize some StructArrays in non-canonical way without any prior transformation.

Public make_encoder_impl() would allow us to re-use existing arrow encoders in our serializers.

@eldargab eldargab added the enhancement Any new improvement worthy of a entry in the changelog label May 7, 2024
@tustvold
Copy link
Contributor

tustvold commented May 7, 2024

I think the encoder details are the kind of thing that would be good to keep as a private implementation detail.

Perhaps we might provide a way to indicate that a given StringArray should be encoded as-is without escaping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

2 participants