Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum required numpy version (1.16.6) has security vulnerability #35846

Open
diegohavenstein opened this issue May 31, 2023 · 2 comments · May be fixed by #35848
Open

Minimum required numpy version (1.16.6) has security vulnerability #35846

diegohavenstein opened this issue May 31, 2023 · 2 comments · May be fixed by #35848

Comments

@diegohavenstein
Copy link

Describe the bug, including details regarding any error messages, version, and platform.

We currently use version 11.0.0 of pyarrow. We run Snyk checks to find vulnerabilities in our third party dependencies

In the version we use, but also on main, the setup.py file states numpy >= 1.16.6 is required (https://github.com/apache/arrow/blob/main/python/setup.py#L451)

This Python version is affected by the following vulnerability: https://security.snyk.io/vuln/SNYK-PYTHON-NUMPY-2321964

To solve the issue, version 1.22.2 or higher should be required

Component(s)

Python

diegohavenstein added a commit to diegohavenstein/arrow that referenced this issue May 31, 2023
The minimum required Numpy version (1.16.6) is affected by the
following vulnerability:
https://security.snyk.io/vuln/SNYK-PYTHON-NUMPY-2321964

With this commit, the minimum required numpy version is increased to
1.22.2, such that Snyk checks do not fail anymore.
@diegohavenstein diegohavenstein removed their assignment May 31, 2023
@danepitkin
Copy link
Contributor

Hey @diegohavenstein, thanks for bringing this up. While I would definitely encourage users to install a numpy version w/o known vulnerabilities, I don't think we want to enforce it in this case given that numpy 1.22.2 was released just a little over a year ago (Feb 3, 2022)[1]. Snyk also reports the known vulnerabilities as low severity, so it's probably best to allow users additional time to upgrade their numpy version.

[1]https://pypi.org/project/numpy/1.22.2/

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Jun 1, 2023

Indeed, it is up to applications and end users to ensure they use a newer numpy version in case those security reports are relevant for them (for many users scripting locally, it is not relevant at all), and not for libraries starting to limit allowed versions.

numpy/numpy#19038 is also an interesting read (about the (non-)usefulness of those CVEs), and essentially disputes the vulnerability, quoting:

Not a meaningful vulnerability because triggering the issue seems only plausible if the malicious party already has the privilege to run NumPy commands. Thus, while a bug, it does not present an escalation of privilege.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants