Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Clean up Assorted Warnings to get a clean nanoarrow build #41478

Closed
WillAyd opened this issue May 1, 2024 · 1 comment
Closed

[C++] Clean up Assorted Warnings to get a clean nanoarrow build #41478

WillAyd opened this issue May 1, 2024 · 1 comment
Assignees
@WillAyd
Labels
Component: C++ Type: bug
Milestone
17.0.0

Comments

@WillAyd
Copy link
Contributor

WillAyd commented May 1, 2024 •
edited

Describe the bug, including details regarding any error messages, version, and platform.

There are still a few outstanding build warnings when trying to compile nanoarrow against Arrow, mostly around unused parameters and redundant moves

https://github.com/apache/arrow-nanoarrow/actions/runs/8912697432/job/24476664226?pr=448#step:7:144

Component(s)

C++
@github-actions github-actions bot mentioned this issue May 1, 2024
Merged
@kou kou changed the title Clean up Assorted Warnings to get a clean nanoarrow build [C++] Clean up Assorted Warnings to get a clean nanoarrow build May 5, 2024
bkietz pushed a commit that referenced this issue May 24, 2024
@WillAyd
GH-41478: [C++] Clean up more redundant move warnings (#41487)
3a4fcff 
### Rationale for this change

Minor warning cleanup for downstream libraries trying to get warning-free builds

### What changes are included in this PR?

Removed redundant std::move from return statements

### Are these changes tested?

Builds cleanly

### Are there any user-facing changes?

No

* GitHub Issue: #41478

Authored-by: Will Ayd <william.ayd@icloud.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
@bkietz bkietz added this to the 17.0.0 milestone May 24, 2024
@bkietz
Copy link
Member

bkietz commented May 24, 2024

Issue resolved by pull request 41487
#41487

@bkietz bkietz closed this as completed May 24, 2024
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@WillAyd @vibhatha
apacheGH-41478: [C++] Clean up more redundant move warnings (apache#4…
28df343 
…1487)

### Rationale for this change

Minor warning cleanup for downstream libraries trying to get warning-free builds

### What changes are included in this PR?

Removed redundant std::move from return statements

### Are these changes tested?

Builds cleanly

### Are there any user-facing changes?

No

* GitHub Issue: apache#41478

Authored-by: Will Ayd <william.ayd@icloud.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WillAyd WillAyd

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
17.0.0
Development

No branches or pull requests
2 participants
@WillAyd @bkietz