Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Support ONNX runtime in RunInference API #22972

Closed
hurutoriya opened this issue Aug 31, 2022 · 8 comments
Closed

[Feature Request]: Support ONNX runtime in RunInference API #22972

hurutoriya opened this issue Aug 31, 2022 · 8 comments

Comments

@hurutoriya
Copy link
Contributor

hurutoriya commented Aug 31, 2022

What would you like to happen?

ONNX Runtime is one of the famous frame work for ML inference in the real world.
https://onnxruntime.ai/
If RunInference API support the ONNX runtime which cover the various ML framework actually.
e.g. not only PyTorch , scikit-learn and TensorFlow but also Transformers(Hugging face) , XGBoost and so on.
https://onnx.ai/supported-tools.html

Issue Priority

Priority: 2

Issue Component

Component: sdk-py-core

@AnandInguva
Copy link
Contributor

cc: @damccorm

@ziqi-ma
Copy link
Contributor

ziqi-ma commented Dec 30, 2022

.take-issue

@ziqi-ma
Copy link
Contributor

ziqi-ma commented Dec 30, 2022

A first-timer question: I see the integration tests for python sdk pull data from a gs location. How can I read/write to that location? Do I need special permission?

@AnandInguva
Copy link
Contributor

AnandInguva commented Dec 31, 2022

I think so. To access apache-beam-testing, you need certain permission. But this shouldn't stop you from the API development. You can develop a local test and I can help you with the location in the later stages.

@ziqi-ma
Copy link
Contributor

ziqi-ma commented Jan 5, 2023

.Thanks - I wrote the API and local unit tests for it. Could you help me review it before I proceed with tests that require remote files? Should I make a draft pr? Thanks.

@AnandInguva
Copy link
Contributor

Yes, that sounds good. Please refer this issue in the PR and tag me as a reviewer.

@ziqi-ma
Copy link
Contributor

ziqi-ma commented Jan 6, 2023

Seems like I cannot add reviewers to draft prs? Here is the PR: #24911

@tvalentyn
Copy link
Contributor

I'm closing this since it seems to have been completed, however onnx functionally currently appears untested and potentially broken, let's follow up in #31254.

@github-actions github-actions bot added this to the 2.57.0 Release milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants