Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Add more information for the /api/v1/bookie/list_disk_file API #4178

Open
crossoverJie opened this issue Jan 15, 2024 · 3 comments
Assignees

Comments

@crossoverJie
Copy link
Contributor

FEATURE REQUEST

Currently:

curl http://localhost:8000/api/v1/bookie/list_disk_file/
{
  "index files" : "",
  "journal files" : "xx.txn\t1213.txn\t",
  "entrylog files" : "66.log\t68.log\t"
}

At the moment, we only get the file name, and I hope we can get more information through this interface; for example, the time of creation, the size of the file, like this:

{
  "entrylog files" : [
    {
      "66.log":{
        "size":1024,
        "creationTime":"1970-01-01T00:00:00Z"
      }
    },
    {
      "67.log":{
        "size":1024,
        "creationTime":"1970-01-01T00:00:00Z"
      }
    }
  ] 
}

This information already exists.

But that affects the return structure, and it's a break change.

If we can't modify this interface directly, maybe we can consider adding a new API?

@shoothzj
Copy link
Member

The compatibility for HTTP API is import, new API is required.

@crossoverJie
Copy link
Contributor Author

If necessary, please assign it to me.

@shoothzj
Copy link
Member

@crossoverJie I think you can open a discuss in mail list first. Let's discuss if these information should be provided by bookkeeper. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants