Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless BookieCheckTask. #4255

Closed
thetumbled opened this issue Mar 29, 2024 · 2 comments
Closed

Useless BookieCheckTask. #4255

thetumbled opened this issue Mar 29, 2024 · 2 comments
Labels

Comments

@thetumbled
Copy link
Contributor

We have listen for the changes of the list of available bookies and readonly bookies. Once changed, we will call org.apache.bookkeeper.replication.Auditor#submitAuditTask to start audit task.

But we have another perodic task for audit bookies.
org.apache.bookkeeper.replication.Auditor#scheduleBookieCheckTask

I doubt with the meaning of such a periodic task as we can get the notification as soon as we receive the event from zookeeper.

@shoothzj
Copy link
Member

what if zookeeper shutdown ungracefully?what if notification lost?I think perodic would work will in this scenario. WDYT?

@thetumbled
Copy link
Contributor Author

what if zookeeper shutdown ungracefully?what if notification lost?I think perodic would work will in this scenario. WDYT?

Make sense, thanks for reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants