Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove asserts from code #995

Open
ivankelly opened this issue Jan 17, 2018 · 0 comments · May be fixed by #4304
Open

Remove asserts from code #995

ivankelly opened this issue Jan 17, 2018 · 0 comments · May be fixed by #4304
Labels
triage/week-33

Comments

@ivankelly
Copy link
Contributor

We currently assert in production code in a few places. These are disabled at runtime, and so have little value. We should replace these with thrown exceptions, or crash the bookie if they are serious enough.

We should also add a checkstyle rule to forbid them.
@ivankelly ivankelly mentioned this issue Jan 17, 2018
Closed
This was referenced Feb 21, 2018
Closed
Closed
@sijie sijie mentioned this issue Jan 15, 2020
Open
This was referenced Apr 19, 2024
Merged
Draft
Merged
shoothzj added a commit that referenced this issue Apr 28, 2024
@shoothzj
test: use junit assert instead of java assert statement in test (#4310)
d52e9e1 
### Motivation

See #995

### Changes

1. use junit assert instead of java assert statement in test
2. delete a unused util class also uses assert statement

Signed-off-by: ZhangJian He <shoothzj@gmail.com>
@shoothzj shoothzj mentioned this issue May 4, 2024
Merged
@shoothzj shoothzj mentioned this issue May 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage/week-33
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] improve: remove asserts from code shoothzj/bookkeeper
2 participants
@ivankelly @sijie