Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement for bookie_journal_JOURNAL_CB_QUEUE_SIZE #4308

Open
michaeljmarshall opened this issue Apr 22, 2024 · 0 comments
Open

Replacement for bookie_journal_JOURNAL_CB_QUEUE_SIZE #4308

michaeljmarshall opened this issue Apr 22, 2024 · 0 comments

Comments

@michaeljmarshall
Copy link
Member

I see that #3830 removed the bookie_journal_JOURNAL_CB_QUEUE_SIZE metric. That metric tracked the number of entries from the point they entered the journal's queue to just after they are synced to disk (assuming journalSyncData=true).

Possible alternatives:

  • bookie_journal_JOURNAL_QUEUE_SIZE - measures the journal queue size. It is incremented when entries are added to the queue and decremented after it was added to the forceWriteRequests queue (that queue is async, so all we know is that it was added to the queue).
  • bookie_journal_JOURNAL_FORCE_WRITE_QUEUE_SIZE - measures the size of the forceWriteRequests queue. It is decremented just before calling fsync.

I think the bookie_journal_JOURNAL_QUEUE_SIZE seems like a good replacement, but it's not exactly the same metric. Is there any interest in re-adding the metric?

@merlimat - since you removed the metric, do you have any guidance? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant