Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karavan-core missing cross-env in package.json #291

Closed
cgballance opened this issue Apr 7, 2022 · 6 comments
Closed

karavan-core missing cross-env in package.json #291

cgballance opened this issue Apr 7, 2022 · 6 comments

Comments

@cgballance
Copy link
Contributor

The test stanza is missing cross-env prior to environment variable set and npm execution

@mgubaidullin
Copy link
Contributor

  1. I got sh: cross-env: command not found error
  2. Looks like project cross-env is "finished" by it's author cross-env is "finished" (now in maintenance mode) kentcdodds/cross-env#257

@cgballance
Copy link
Contributor Author

cgballance commented Apr 7, 2022

npm install -g cross-env
you must be on a new vm or ???
It's being used in karavan-vscode's package.json too, so it is consistent.

i don't know of an alternative unless you want to get rid of it from vscode's package.json too.
It has been in karavan-vscode's package.json since original commit.

@mgubaidullin
Copy link
Contributor

Agree. it is used in karavan-vscode to set NODE_ENV=development
Why do we need it in karavan-core?

@cgballance
Copy link
Contributor Author

needed for a build on windows(native shell).

@mgubaidullin
Copy link
Contributor

In that case it should be in devDependencies

@cgballance
Copy link
Contributor Author

good catch, i'll get that in, using the same version as in vscode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants