Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ubuntu workflow to also build RelWithDebInfo and execute the unit tests #655

Open
rlenferink opened this issue Sep 24, 2023 · 2 comments
Open

Update ubuntu workflow to also build RelWithDebInfo and execute the unit tests #655

rlenferink opened this issue Sep 24, 2023 · 2 comments
Labels
build/environment Categorizes an issue or PR relevant to the build environment. good first issue Denotes an issue ready for a new contributor

Comments

@rlenferink
Copy link
Member

rlenferink commented Sep 24, 2023 •
edited by PengZheng

I think it would be good to also execute the RelWithDebInfo build and unit tests.

This reduces the possibility of issues being found during a release (context).

Suggestion: update the .github/workflows/ubuntu.yml to execute a matrix build for:

  • Conan
    • Debug -> all features enabled
    • RelWithDebInfo -> all features enabled
    • RelWithDebInfo -> only the default features enabled
  • Apt
    • Debug -> all features enabled
    • RelWithDebInfo -> all features enabled
    • RelWithDebInfo -> only the default features enabled
@PengZheng PengZheng assigned PengZheng and unassigned PengZheng Sep 24, 2023
@PengZheng PengZheng added good first issue Denotes an issue ready for a new contributor build/environment Categorizes an issue or PR relevant to the build environment. labels Sep 24, 2023
@PengZheng
Copy link
Contributor

PengZheng commented Sep 25, 2023 •
edited

RelWithDebInfo -> all features enabled for Conan has been addressed by #657.

@PengZheng
Copy link
Contributor

I should reminds that for Conan build, all features are off by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build/environment Categorizes an issue or PR relevant to the build environment. good first issue Denotes an issue ready for a new contributor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PengZheng @rlenferink