Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not seem to enforce the default build tools version #659

Closed
brodybits opened this issue Feb 10, 2019 · 1 comment
Closed

Does not seem to enforce the default build tools version #659

brodybits opened this issue Feb 10, 2019 · 1 comment

Comments

@brodybits
Copy link
Contributor

Related to issue #658: in case the user does not explicitly configure cdvBuildToolsVersion, no default build tools version such as defaultBuildToolsVersion ("28.0.3") is enforced in the following lines:

if (ext.cdvBuildToolsVersion == null) {
ext.cdvBuildToolsVersion = privateHelpers.findLatestInstalledBuildTools()
//ext.cdvBuildToolsVersion = project.ext.defaultBuildToolsVersion
}

@erisu
Copy link
Member

erisu commented Jul 21, 2021

I am closing this ticket as resolved in Cordova-Android 10. #1212

The referenced code was removed.

During the refactoring of the Gradle scripts, the default build tools version is set first. Next, it will attempt to find the latest installed build tools while using the default as the minimum required version. If the latest installed version is lower than the minimum, the build process will halt and the user is notified that they must install the correct version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants