Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document: CORDOVA_JAVA_HOME environment variable #1292

Closed
breautek opened this issue Apr 3, 2023 · 4 comments · Fixed by #1293
Closed

Document: CORDOVA_JAVA_HOME environment variable #1292

breautek opened this issue Apr 3, 2023 · 4 comments · Fixed by #1293
Assignees

Comments

@breautek
Copy link
Contributor

breautek commented Apr 3, 2023

As pointed out by apache/cordova-android#1229 (comment)

The CORDOVA_JAVA_HOME is not documented as an option. CORDOVA_JAVA_HOME will take precedence over JAVA_HOME if set.

The feature was added in v10 of cordova-android.

@paulwwisl
Copy link

PR #1293 is OK,

The JAVA_HOME environment variable must be set according to your JDK installation path when installing on a Windows environment.

This is other issue however, as for sure JAVA_HOME works not only on Windows, but macOS as well.

I bet specific OS should be omitted.

@breautek
Copy link
Contributor Author

This is other issue however, as for sure JAVA_HOME works not only on Windows, but macOS as well.

I bet specific OS should be omitted.

For sure... I didn't change what was already, there I just appended. However this is definitely true and I think this is a good opportunity to address that. Thank you for pointing that out.

@breautek
Copy link
Contributor Author

breautek commented May 3, 2023

It is live at https://cordova.apache.org/docs/en/11.x/guide/platforms/android/index.html#java-development-kit-jdk

And it feels like it should be moved to section https://cordova.apache.org/docs/en/11.x/guide/platforms/android/index.html#setting-environment-variables

I would... also agree with that. A PR is welcome to move it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants