Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cordova command create apps by default do not include <access origin="*">? #1337

Open
3 tasks done
whilename opened this issue Jun 29, 2023 · 2 comments
Open
3 tasks done
Labels

Comments

@whilename
Copy link

Bug Report

Problem

In NodeJs v18 & Cordova@11.1 environment, after I created a project using "cordova create sampleapp com.sample.app SampleApp" command, "config.xml" file is not included , causing the program to be unable to access external web-sites.

What is expected to happen?

I tried to create the project in cordova@9 version, "config.xml" file and it will contain by default,
I saw in the official cordova documentation guide(https://cordova.apache.org/docs/en/11.x/guide/appdev/allowlist/index.html#network-request-allow-list) that it is automatically added by default.

What does actually happen?

so I was wondering why is not included by default in cordova@11.* version?

Command or Code

cordova create sampleapp com.sampleapp.com SampleApp
cordova platform add android
cordova plugin add cordova-plugin-dialogs cordova-plugin-network-information

Environment, Platform, Device

Windows 11 & NodeJS v18 & Cordova@11.1 & Android

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
@erisu
Copy link
Member

erisu commented Jun 29, 2023

Defaulting to allow access to all origins poses a risk. It was decided to be removed as a default.

It is recommended that developers understand and configure what should be accessible.

It appears the docs were not updated.

@breautek
Copy link
Contributor

Moving this to the cordova-docs repo because I think we should treat this as a doc bug.

@breautek breautek transferred this issue from apache/cordova-cli Oct 21, 2023
@breautek breautek added the bug label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants