Run client-side JS through Babel if desired #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to 🐣 New PR / Untriaged
in Apache Cordova: Tooling Pull Requests
raphinesse
changed the title
Apache Cordova: Tooling Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to ✅ Approved, waiting for Merge
Oct 10, 2019
This comment has been minimized.
This comment has been minimized.
raphinesse
force-pushed
the
babel
branch
2 times, most recently
from
d44ac89
to
d5f1294
Compare
|
Unfortunately the code transformed by Babel is missing polyfills. Babel can include Alternatively we could easily add a pre-bundled version of Closing this until I figure out how to solve this. |
Apache Cordova: Tooling Pull Requests
automation
moved this from ✅ Approved, waiting for Merge
to ☠️ Closed/Abandoned
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
The ones we want to be affected
Motivation and Context
Closes #206
Description
This allows to set babel targets for each platform, so that the latest and greatest JavaScript we write will be compiled to whatever is compatible with the platform we're building for.
Testing
The babel transform is also applied to the
cordova-jsbuild for our automated tests (which also include code from the Android and iOS platforms). The tests still pass after that.