Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [dolphinscheduler-master] WorkflowExecuteRunnable's executeTask method return incorrect value #15740

Closed
3 tasks done
ZhongJinHacker opened this issue Mar 19, 2024 · 2 comments · May be fixed by #15741
Closed
3 tasks done

[Bug] [dolphinscheduler-master] WorkflowExecuteRunnable's executeTask method return incorrect value #15740

ZhongJinHacker opened this issue Mar 19, 2024 · 2 comments · May be fixed by #15741
Assignees
@ZhongJinHacker
Labels
bug Something isn't working Stale

Comments

@ZhongJinHacker
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

In WorkflowExecuteRunnable's executeTask method block, when processService.submitTask return false, it will return true. and this return value will cause the boolean variable named taskFailedSubmit cannot go into the correct state. Due to taskFailedSubmit is WorkflowExecuteRunnable's member variable, it will cause the method named hasFailedTask cannot return the correct results

image

image

What you expected to happen

let me fix it

How to reproduce

when the db can not work， and at the same time ，the program call the processService.submitTask in the executeTask method block, it will reproduce the situation. Or make a unit test. it also can reproduce the situation

Anything else

No response

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@ZhongJinHacker ZhongJinHacker added bug Something isn't working Waiting for reply Waiting for reply labels Mar 19, 2024
@ZhongJinHacker ZhongJinHacker mentioned this issue Mar 19, 2024
Open
@SbloodyS SbloodyS removed the Waiting for reply Waiting for reply label Mar 21, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Apr 21, 2024
@github-actions GitHub Actions
Copy link

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZhongJinHacker ZhongJinHacker

Labels
bug Something isn't working Stale
Projects
None yet
Milestone
No milestone
2 participants
@ZhongJinHacker @SbloodyS