[Improvement][Master] Add Misfire policy control in schedule #15987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pegasas
requested review from
caishunfeng,
EricGao888 and
SbloodyS
as code owners
pegasas
changed the title
ruanwenjun
reviewed
May 14, 2024
...inscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/MisfirePolicy.java
Outdated
Show resolved
Hide resolved
| DROP PROCEDURE modify_data_t_ds_audit_log_input_entry; | ||
|
|
||
| ALTER TABLE t_ds_schedules ADD COLUMN misfire_policy tinyint(4) NOT NULL; |
There was a problem hiding this comment.
Need to refresh the history data.
ruanwenjun
reviewed
May 14, 2024
Comment on lines
88
to
100
| switch (schedule.getMisfirePolicy()) { | ||
| case DONOTHING: | ||
| cronScheduleBuilder.withMisfireHandlingInstructionDoNothing(); | ||
| break; | ||
| case FIREANDPROCEED: | ||
| cronScheduleBuilder.withMisfireHandlingInstructionFireAndProceed(); | ||
| break; | ||
| case IGNOREMISFIRES: | ||
| default: | ||
| cronScheduleBuilder.withMisfireHandlingInstructionIgnoreMisfires(); | ||
| break; | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this PR finished? how can we set this property?
rickchengx
reviewed
May 15, 2024
| * 0 ending process when some tasks failed. | ||
| * 1 continue running when some tasks failed. | ||
| **/ | ||
| IGNOREMISFIRES(-1, "ignoremisfires"), |
There was a problem hiding this comment.
May I ask Why does code starts from -1?
rickchengx
reviewed
May 15, 2024
| /** | ||
| * misfire policy when using quartz scheduler | ||
| */ | ||
| public enum MisfirePolicy { |
There was a problem hiding this comment.
What is the granularity of this policy, server level or scheduling level? If it is a scheduling level, is a corresponding front end needed to allow users to set it?
Also, doc needs to be updated
|
Mark |
pegasas
force-pushed
the
issues/15986
branch
2 times, most recently
from
867899b
to
7284121
Compare
Update dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/MisfirePolicy.java Co-authored-by: Wenjun Ruan <wenjun@apache.org> fix
songjianet
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix: #15986
Brief change log
Now our trigger are configured in fixed misfire instruction.
We can let each cronjob to choose theirselves.
Verify this pull request