From d3fddea18c348eb93137259387023586dd8a3779 Mon Sep 17 00:00:00 2001 From: caishunfeng Date: Thu, 7 Mar 2024 12:06:08 +0800 Subject: [PATCH] fix switch js, add black key --- .../server/master/utils/SwitchTaskUtils.java | 4 ++++ .../server/master/utils/SwitchTaskUtilsTest.java | 10 ++++++++++ 2 files changed, 14 insertions(+) diff --git a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtils.java b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtils.java index 40686474a45b..2837f69022f0 100644 --- a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtils.java +++ b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtils.java @@ -50,6 +50,10 @@ public class SwitchTaskUtils { "eval", "function", "import", + ".", + "()", + "[", + "]", "\\\\"); static { diff --git a/dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtilsTest.java b/dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtilsTest.java index e0654882ec38..ef289d075786 100644 --- a/dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtilsTest.java +++ b/dolphinscheduler-master/src/test/java/org/apache/dolphinscheduler/server/master/utils/SwitchTaskUtilsTest.java @@ -65,5 +65,15 @@ public void testIllegalCondition() { SwitchTaskUtils.generateContentWithTaskParams(contentWithUnicode, globalParams, varParams); }); + String contentWithSpecify1 = "cmd.abc"; + Assertions.assertThrowsExactly(IllegalArgumentException.class, () -> { + SwitchTaskUtils.generateContentWithTaskParams(contentWithSpecify1, globalParams, varParams); + }); + + String contentWithSpecify2 = "cmd()"; + Assertions.assertThrowsExactly(IllegalArgumentException.class, () -> { + SwitchTaskUtils.generateContentWithTaskParams(contentWithSpecify2, globalParams, varParams); + }); + } }