From ad11f3444f86e0c991bf39208abcd7aefbac8b6a Mon Sep 17 00:00:00 2001
From: EricGao888 <ericgao.apache@gmail.com>
Date: Wed, 20 Mar 2024 15:34:12 +0800
Subject: [PATCH] remove unused method

---
 .../dao/mapper/ProcessInstanceMapper.java     | 16 --------------
 .../dao/mapper/ProcessInstanceMapper.xml      | 17 ---------------
 .../dao/mapper/ProcessInstanceMapperTest.java | 21 -------------------
 3 files changed, 54 deletions(-)

diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.java
index 509bf7ca4d28..a0a81374f507 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.java
@@ -199,22 +199,6 @@ ProcessInstance queryLastSchedulerProcess(@Param("processDefinitionCode") Long d
                                               @Param("endTime") Date endTime,
                                               @Param("testFlag") int testFlag);
 
-    /**
-     * query last running process instance
-     *
-     * @param definitionCode definitionCode
-     * @param startTime      startTime
-     * @param endTime        endTime
-     * @param testFlag       testFlag
-     * @param stateArray     stateArray
-     * @return process instance
-     */
-    ProcessInstance queryLastRunningProcess(@Param("processDefinitionCode") Long definitionCode,
-                                            @Param("startTime") Date startTime,
-                                            @Param("endTime") Date endTime,
-                                            @Param("testFlag") int testFlag,
-                                            @Param("states") int[] stateArray);
-
     /**
      * query last manual process instance
      *
diff --git a/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml b/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
index 80c008d0fdb9..baeb5f90a710 100644
--- a/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
+++ b/dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml
@@ -206,23 +206,6 @@
         </if>
         order by end_time desc limit 1
     </select>
-    <select id="queryLastRunningProcess" resultType="org.apache.dolphinscheduler.dao.entity.ProcessInstance">
-        select
-        <include refid="baseSql"/>
-        from t_ds_process_instance
-        where process_definition_code=#{processDefinitionCode} and test_flag=#{testFlag}
-        <if test="states !=null and states.length != 0">
-            and state in
-            <foreach collection="states" item="i" index="index" open="(" separator="," close=")">
-                #{i}
-            </foreach>
-        </if>
-        <if test="startTime!=null and endTime != null ">
-            and ((schedule_time <![CDATA[ >= ]]> #{startTime} and schedule_time <![CDATA[ <= ]]> #{endTime})
-            or (start_time <![CDATA[ >= ]]> #{startTime} and start_time <![CDATA[ <= ]]> #{endTime}))
-        </if>
-        order by start_time desc limit 1
-    </select>
     <select id="queryLastManualProcess" resultType="org.apache.dolphinscheduler.dao.entity.ProcessInstance">
         select t1.*
         from
diff --git a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapperTest.java b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapperTest.java
index 1a6049aeb1b5..39b8d04e4d12 100644
--- a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapperTest.java
+++ b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapperTest.java
@@ -269,27 +269,6 @@ public void testQueryLastSchedulerProcess() {
         processInstanceMapper.deleteById(processInstance.getId());
     }
 
-    /**
-     * test query last running process instance
-     */
-    @Test
-    public void testQueryLastRunningProcess() {
-        ProcessInstance processInstance = insertOne();
-        processInstance.setState(WorkflowExecutionStatus.RUNNING_EXECUTION);
-        processInstanceMapper.updateById(processInstance);
-
-        int[] stateArray = new int[]{
-                WorkflowExecutionStatus.RUNNING_EXECUTION.ordinal(),
-                WorkflowExecutionStatus.SUBMITTED_SUCCESS.ordinal()};
-
-        ProcessInstance processInstance1 = processInstanceMapper
-                .queryLastRunningProcess(processInstance.getProcessDefinitionCode(), null, null,
-                        processInstance.getTestFlag(), stateArray);
-
-        Assertions.assertNotEquals(null, processInstance1);
-        processInstanceMapper.deleteById(processInstance.getId());
-    }
-
     /**
      * test query last manual process instance
      */