Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code contains multiple always true byte < checks #2799

Open
Marcono1234 opened this issue May 7, 2023 · 0 comments
Open

Code contains multiple always true byte < checks #2799

Marcono1234 opened this issue May 7, 2023 · 0 comments

Comments

@Marcono1234
Copy link

Describe the bug
The code contains multiple x < ... checks where x is a byte and the right-hand side is > 127 (= max byte value), so these conditions are always true:

Not completely sure what the fix here is, maybe (byte & 0xFF) < .... And also for StringFunctions maybe it should be 128 (decimal) instead of 0x128 (hex, = 296 decimal); at least the 0x128 looks a bit suspicious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant