New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics for merge buffer usage #4345
Comments
Hey. Can I take up this issue? I have recently started using druid in one of my project and really liked the product. I am new to open source so don't want to pick something big at this stage. |
Hi @Sarvesh1990, definitely! For the first thing (number of merge buffers allocated), that should probably be the number of merge buffers outstanding at a point in time. For an example of another metric that does this, check For the second thing (amount of time spent waiting for a merge buffer), that should probably be a query metric, so the thing to do would be to add a new method like These could be done as separate PRs since they are not related. |
No worries @Sarvesh1990. I left a review on your PR. |
This issue has been marked as stale due to 280 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. |
@gianm Can you re-open the issue? I think this is still an important feature to have. |
Would be nice to have two metrics for merge buffers, so operators can know if they are frequently maxed out on merge buffers.
The text was updated successfully, but these errors were encountered: