Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web Console] Datasource page support search datasource by keyword #16371

Merged
merged 14 commits into from May 24, 2024
Merged

[Web Console] Datasource page support search datasource by keyword #16371

merged 14 commits into from May 24, 2024
+120 −73

Conversation

fectrain
Copy link
Contributor

@fectrain fectrain commented May 2, 2024 •
edited

Fixes #16370 .

Description

A5AE383C-D454-49B9-9A89-501834FD6617 C9267A20-0EF4-4E3E-B5E1-B1550CF31968

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@fectrain fectrain changed the title [Web Console] Segment page support search by datasource [Web Console] Datasource page support search datasource by keyword May 2, 2024
vogievetsky
vogievetsky requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really cool, thank you for the change. Added some style comments, also you should run script/licenses (from the web-console directory) to update the license list since you added a package. Do these changes + resolve conflicts and it is good to go IMO

web-console/src/components/segment-timeline/segment-timeline.tsx Show resolved Hide resolved
web-console/src/components/segment-timeline/segment-timeline.tsx Outdated Show resolved Hide resolved
@fectrain
Copy link
Contributor Author

@vogievetsky Thank you so much for helping on this, I have updated the code as recommended.
BTW, the one failing check seems to be introduced by another merge, and should be able to fix by this #16469

@fectrain
Copy link
Contributor Author

Hi, @vogievetsky I just merged the latest master branch and now all CI checks has passed, hope it is ready for merging, thank you.

vogievetsky
vogievetsky approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you for addressing the feedback!

@vogievetsky vogievetsky merged commit 6bc2953 into apache:master May 24, 2024
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vogievetsky vogievetsky Awaiting requested review from vogievetsky

Assignees

@vogievetsky vogievetsky

Labels
Area - Dependencies Area - Web Console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filter feature for DataSource section of Router page
2 participants
@fectrain @vogievetsky