Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client.WithClientCheck() should set check to false instead of true. #2652

Closed
chickenlj opened this issue Apr 3, 2024 · 2 comments · Fixed by #2680
Closed

client.WithClientCheck() should set check to false instead of true. #2652

chickenlj opened this issue Apr 3, 2024 · 2 comments · Fixed by #2680
Assignees
@FoghostCn

Comments

@chickenlj
Copy link
Contributor

chickenlj commented Apr 3, 2024 •
edited

The default value of check is true, so client.WithClientCheck() should set check to false instead of true.

cli, err := client.NewClient(
   client.WithClientCheck(),
}
@FoghostCn
Copy link
Contributor

should named client.WithClientNoCheck() ?

@chickenlj
Copy link
Contributor Author

should named client.WithClientNoCheck() ?

Yeah, I think so.

@FoghostCn FoghostCn mentioned this issue May 18, 2024
Merged
@FoghostCn FoghostCn self-assigned this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FoghostCn FoghostCn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change method WithClientCheck to WithClientNoCheck FoghostCn/dubbo-go
2 participants
@FoghostCn @chickenlj