-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State transition not performed with shortest distance #2751
Labels
bug
Something isn't working
Comments
It seems to be related to state priority or state transition priority. I
don't think Helix optimizes the cost of transition today. I vote for
enhancing this.
Best Regards,
Jiajun
…On Thu, Feb 1, 2024 at 1:15 PM Xiaotian (Jackie) Jiang < ***@***.***> wrote:
Describe the bug
The state machine has the following state transitions:
- CONSUMING -> OFFLINE
- OFFLINE -> DROPPED
- CONSUMING -> DROPPED
When a partition of state CONSUMING is dropped from the ideal state, we
expect one state transition CONSUMING -> DROPPED to be sent. But we
observe it is performed as 2 state transitions: CONSUMING -> OFFLINE
followed by OFFLINE -> DROPPED
Is this the expected behavior? Could this be a regression?
—
Reply to this email directly, view it on GitHub
<#2751>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANYM2DKKTI662ZOVS5AJVLYRQAX7AVCNFSM6AAAAABCVTLMQKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYTGNBZG44TAOI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@jiajunwang Thanks for the response! Is there a workaround to force Helix to do |
Drop and Offline states are default ones and AFAICR they have default
priority too. We can try to overwrite in SMD and see if prioritizing DROP
state and related transitions will work or not.
I will need to double check the latest code to ensure this though. Will try
to do it when I have time.
Best Regards,
Jiajun
…On Sat, Feb 3, 2024 at 11:42 AM Xiaotian (Jackie) Jiang < ***@***.***> wrote:
@jiajunwang <https://github.com/jiajunwang> Thanks for the response! Is
there a workaround to force Helix to do CONSUMING -> DROPPED as 1 state
transition instead of 2?
—
Reply to this email directly, view it on GitHub
<#2751 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANYM2B5CWJBYGEB5F3GGT3YR2HLHAVCNFSM6AAAAABCVTLMQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGQZTQNRZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The state machine has the following state transitions:
CONSUMING
->OFFLINE
OFFLINE
->DROPPED
CONSUMING
->DROPPED
When a partition of state
CONSUMING
is dropped from the ideal state, we expect one state transitionCONSUMING
->DROPPED
to be sent. But we observe it is performed as 2 state transitions:CONSUMING
->OFFLINE
followed byOFFLINE
->DROPPED
Is this the expected behavior? Could this be a regression?
The text was updated successfully, but these errors were encountered: