Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Support querying via prometheus for rocketMQ #1810

Open
Alanxtl opened this issue Apr 22, 2024 · 5 comments
Open

[Question] Support querying via prometheus for rocketMQ #1810

Alanxtl opened this issue Apr 22, 2024 · 5 comments
Labels
question Further information is requested

Comments

@Alanxtl
Copy link
Contributor

Alanxtl commented Apr 22, 2024

Question

According to the doc, rocketMQ is supported for querying metrics using the Prometheus protocol. Currently the code seems to use the method of creating an instance to query information (#1046), so the metrics that could be queried seems limited and its a waste of connection resource. I think it is necessary to support querying via prometheus for rocketMQ.

btw, I'm not sure if I should create a [Task], so I just create a [Question].

@Alanxtl Alanxtl added the question Further information is requested label Apr 22, 2024
@tomsun28
Copy link
Contributor

@Ceilzcx how about this, suggest use Prometheus protocol to query the rocketMQ metrics too.

@Ceilzcx
Copy link
Contributor

Ceilzcx commented Apr 23, 2024

Can you briefly describe the advantages of changing to this?
Because now too few metrics to monitor rocketmq,and sdk is not support or other reason?

@Alanxtl Alanxtl closed this as completed Apr 23, 2024
@Alanxtl Alanxtl reopened this Apr 23, 2024
@Alanxtl
Copy link
Contributor Author

Alanxtl commented Apr 23, 2024

@Ceilzcx, according to apache/rocketmq#5615 (comment) and RIP-46, they have introduced new metrics in Prometheus way. See doc for detailed metrics.

Besides, RIP-46, also mentioned that

using mqadmin tools, which puts additional pressure on broker and client.

@Ceilzcx
Copy link
Contributor

Ceilzcx commented Apr 23, 2024

@Ceilzcx, according to apache/rocketmq#5615 (comment) and RIP-46, they have introduced new metrics in Prometheus way. See doc for detailed metrics.

Besides, RIP-46, also mentioned that

using mqadmin tools, which puts additional pressure on broker and client.

good idea. Need to be compatible with old logic?

@Alanxtl
Copy link
Contributor Author

Alanxtl commented Apr 24, 2024

@Ceilzcx, according to apache/rocketmq#5615 (comment) and RIP-46, they have introduced new metrics in Prometheus way. See doc for detailed metrics.
Besides, RIP-46, also mentioned that

using mqadmin tools, which puts additional pressure on broker and client.

good idea. Need to be compatible with old logic?

I do not think it is necessary, the new method covers the metrics of the old one can query after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants