Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split AbstractHistoryDataStorage class #1885

Open
xuziyang opened this issue Apr 29, 2024 · 0 comments
Open

Split AbstractHistoryDataStorage class #1885

xuziyang opened this issue Apr 29, 2024 · 0 comments

Comments

@xuziyang
Copy link
Contributor

Description

org.apache.hertzbeat.warehouse.store.AbstractHistoryDataStorage violates the interface segregation principle:

In this class, there are the following three methods: saveData (), getHistoryMetricData () and getHistoryIntervalMetricData (). DataStorageDispatch uses the method saveData () to save historical data, and does not use the other two query-related methods. Similarly, the alarm and chart modules only use two query-related methods, and do not use data-related methods.

Can be assigned to me @tomsun28

Task List

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant