Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] why in MetricsDataController injection is a collection of stores instead of a single store instance? #1933

Open
xuziyang opened this issue May 8, 2024 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@xuziyang
Copy link
Contributor

xuziyang commented May 8, 2024

Question

image

Since only one realtimeDataStore and one historyDataStore can be configured, why in MetricsDataController injection is a collection of stores instead of a single store instance.

I think it's better to inject a single instance. If the community agrees, you can assign this task to me. @tomsun28

@xuziyang xuziyang added the question Further information is requested label May 8, 2024
@tomsun28
Copy link
Contributor

tomsun28 commented May 8, 2024

Hi, this is due to historical configuration. Although we can only configure one store, many users will configure multiple ones, or forget to turn off the default one, causing the operation to fail. So here we changed to inject multiple beans and then select one.

I think we can update it to inject only one instance.
And we need to discuss whether we need to start reporting errors when there is no bean when startup.

@xuziyang
Copy link
Contributor Author

xuziyang commented May 8, 2024

Hi, this is due to historical configuration. Although we can only configure one store, many users will configure multiple ones, or forget to turn off the default one, causing the operation to fail. So here we changed to inject multiple beans and then select one.

I think we can update it to inject only one instance. And we need to discuss whether we need to start reporting errors when there is no bean when startup.

from the documentation, it is possible to use only the real-time data storage and not the historical data repository.

since it's expected that no historical data repository is configured, I think it's good to give a warning at system startup if no historical data repository is configured

@tomsun28
Copy link
Contributor

tomsun28 commented May 8, 2024

ok👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants