New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VL] scan time metric is 0 #5606

Open

zhouyuan opened this issue May 6, 2024 · 5 comments

Labels

bug

Contributor

zhouyuan commented May 6, 2024

Backend

VL (Velox)

Bug description

The total time scan metric seems to be wrong

Spark version

None

Spark configurations

No response

System information

No response

Relevant logs

No response

zhouyuan added the bug label

Contributor Author

zhouyuan commented May 6, 2024

xumingming mentioned this issue

[VL] Metrics for Scan seems wrong #5094

Closed

Contributor

ulysses-you commented May 6, 2024

raw input bytes related to facebookincubator/velox#8545 ? cc @JkSelf

Contributor

surnaik commented May 6, 2024

Investigating - https://github.com/facebookincubator/velox/blob/9fde0a2c4bc392d71524e43472604a506b02b6b9/velox/dwio/common/InputStream.cpp#L86

stats_ is NULL

Contributor

surnaik commented May 6, 2024

Passing the received ioStats to https://github.com/facebookincubator/velox/blob/9fde0a2c4bc392d71524e43472604a506b02b6b9/velox/dwio/common/DirectBufferedInput.h#L115 fixes the issue.

Contributor

JkSelf commented May 14, 2024

@zhouyuan @surnaik @ulysses-you
The issues with incorrect rawInputBytes and scan time metrics are addressed in the pull request at facebookincubator/velox#9801.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment