Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Use FileChannel to replace FileOutputStream and DataOutputStream in LocalFileWriter #1613

Closed
3 tasks done
rickyma opened this issue Apr 1, 2024 · 2 comments
Closed
3 tasks done

[Improvement] Use FileChannel to replace FileOutputStream and DataOutputStream in LocalFileWriter #1613

rickyma opened this issue Apr 1, 2024 · 2 comments

Comments

@rickyma
Copy link
Contributor

rickyma commented Apr 1, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

FileChannel can provide better performance than traditional IO streams, as it can take advantage of the underlying operating system's native IO capabilities, such as memory-mapped files and direct buffer access.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@rickyma
Copy link
Contributor Author

rickyma commented Apr 1, 2024 •
edited

If you have any ideas on this, please let me know. Anyone will be welcome to pick this up.

@rickyma
Copy link
Contributor Author

rickyma commented May 20, 2024

Close this because FileChannel will cause RSS(Resident Set Size) to grow unexpectedly.

@rickyma rickyma closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rickyma