You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched in the issues and found no similar issues.
Describe the bug
FileSegmentManagedBuffer#nioByteBuffer read file directly without cache at now. ShuffleDataResult getData() may read file twice when buffer instanceof FileSegmentManagedBuffer, it‘s not Consistent with NettyManagedBuffer.
if (buffer.nioByteBuffer().hasArray()) {
return buffer.nioByteBuffer().array();
}
expect:
FileSegmentManagedBuffer#nioByteBuffer should add a buffer to hold read file result to avoid multiple read file
Affects Version(s)
master
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered:
xumanbu
pushed a commit
to xumanbu/incubator-uniffle
that referenced
this issue
Apr 18, 2024
Code of Conduct
Search before asking
Describe the bug
FileSegmentManagedBuffer#nioByteBuffer read file directly without cache at now.
ShuffleDataResult getData()
may read file twice when buffer instanceof FileSegmentManagedBuffer, it‘s not Consistent withNettyManagedBuffer
.expect:
FileSegmentManagedBuffer#nioByteBuffer should add a buffer to hold read file result to avoid multiple read file
Affects Version(s)
master
The text was updated successfully, but these errors were encountered: