Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Optimized FileSegmentManagedBuffer.nioByteBuffer to avoid multiple read file #1658

Open
3 tasks done
xumanbu opened this issue Apr 18, 2024 · 0 comments · May be fixed by #1659
Open
3 tasks done

[Bug] Optimized FileSegmentManagedBuffer.nioByteBuffer to avoid multiple read file #1658

xumanbu opened this issue Apr 18, 2024 · 0 comments · May be fixed by #1659

Comments

@xumanbu
Copy link
Contributor

xumanbu commented Apr 18, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

FileSegmentManagedBuffer#nioByteBuffer read file directly without cache at now.
ShuffleDataResult getData() may read file twice when buffer instanceof FileSegmentManagedBuffer, it‘s not Consistent with NettyManagedBuffer.

   if (buffer.nioByteBuffer().hasArray()) {
      return buffer.nioByteBuffer().array();
    }

expect:
FileSegmentManagedBuffer#nioByteBuffer should add a buffer to hold read file result to avoid multiple read file

Affects Version(s)

master

  • Yes I am willing to submit a PR!
xumanbu pushed a commit to xumanbu/incubator-uniffle that referenced this issue Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant