Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Assertions will not take effect during production runtime #1668

Open
2 of 3 tasks
rickyma opened this issue Apr 25, 2024 · 0 comments
Open
2 of 3 tasks

[Bug] Assertions will not take effect during production runtime #1668

rickyma opened this issue Apr 25, 2024 · 0 comments

Comments

@rickyma
Copy link
Contributor

rickyma commented Apr 25, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

We have many assertions in our code, and these will only take effect when running test cases because the -ea parameter is enabled when running tests. However, they will not take effect in actual production because we do not include the -ea parameter in the startup arguments, and enabling assertions can also impact performance, so it is not recommended to enable them. We should refactor them, maybe replacing these assertions with exception-throwing methods.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant