Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test name reporting when test is in a base class #923

Open
1 task done
paulirwin opened this issue Feb 25, 2024 · 0 comments
Open
1 task done

Fix test name reporting when test is in a base class #923

paulirwin opened this issue Feb 25, 2024 · 0 comments
Labels
is:enhancement New feature or request is:task A chore to be done pri:normal testability up-for-grabs This issue is open to be worked on by anyone

Comments

@paulirwin
Copy link
Contributor

paulirwin commented Feb 25, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Task description

Context: #914 (comment)

From @NightOwl888:

we should have a new issue about fixing test reports so the correct superclass is reported for tests that are declared in a base class.

NUnit reports the name of the class that the [Test] attribute it finds is declared in. We need it to report the name of the top level superclass that inherited the class that the [Test] attribute is declared in, since we have tests in test fixture classes that are designed specifically to be inherited so standardized tests can be reused. Since several of these classes are in the test framework, this issue affects end users of the test framework as well as internally.

As a workaround, we currently override test methods, redefine the [Test] attribute on the superclass, and cascade the call to the base class. This gets NUnit to display the proper class name, but it obviously doesn't scale well.

Also see: #914 (comment)

@paulirwin paulirwin added the is:task A chore to be done label Feb 25, 2024
@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone testability is:enhancement New feature or request pri:normal labels Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:enhancement New feature or request is:task A chore to be done pri:normal testability up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

2 participants