Remove unnecessary[MethodImpl(MethodImplOptions.NoInlining)]

[paulirwin]

Note that we have added [MethodImpl(MethodImplOptions.NoInlining)] more liberally than what was actually required. For example, for this case we have added it to every method named Flush in the whole solution. There may be a slight performance improvement if we allowed inlining everywhere except for the specific methods that are actually being scanned for in the stack traces of all tests.

This is low priority, but perhaps we should add an issue to remove unnecessary [MethodImpl(MethodImplOptions.NoInlining)] attributes. An analysis of which specific methods are being scanned for in the stack trace would be required to work this out, though. Or they could be removed one at a time and rolled back if removing the attribute causes a failure in any one of multiple test runs.

Originally posted by @NightOwl888 in #926 (comment)